Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IE 187(Maximum Wait Time) and 188(Millisecond Time Stamp) to gtp_v2.py #4376

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mlugo-apx
Copy link

Adds to the GTPv2 protocol capability of Scapy by adding support for the Information Elements 187(Maximum Wait Time) and 188(Millisecond Time Stamp).

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.23%. Comparing base (8cea357) to head (36ec027).
Report is 37 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (8cea357) and HEAD (36ec027). Click for more details.

HEAD has 19 uploads less than BASE | Flag | BASE (8cea357) | HEAD (36ec027) | |------|------|------| ||20|1|
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4376       +/-   ##
===========================================
- Coverage   82.21%   49.23%   -32.99%     
===========================================
  Files         353      346        -7     
  Lines       83586    77806     -5780     
===========================================
- Hits        68723    38304    -30419     
- Misses      14863    39502    +24639     
Files Coverage Δ
scapy/contrib/gtp_v2.py 91.44% <100.00%> (-3.98%) ⬇️

... and 265 files with indirect coverage changes

@gpotter2
Copy link
Member

gpotter2 commented May 4, 2024

Thanks for the PR ! Could you add a unit test that builds and/or dissects those new packets?
Thanks

@mlugo-apx
Copy link
Author

Thanks for the PR ! Could you add a unit test that builds and/or dissects those new packets? Thanks

Is there anywhere that shows how to build the test?

@gpotter2
Copy link
Member

gpotter2 commented May 7, 2024

You can read the doc: https://scapy.readthedocs.io/en/latest/development.html#testing-with-utscapy

but the format is trivial to understand.

You can add them to:
https://github.com/secdev/scapy/blob/master/test/contrib/gtp_v2.uts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants